Brendan Forster

Results 633 comments of Brendan Forster

Thanks for your patience with us everyone. I've deployed a fix to the GraphQL API for Projects which should allow private projects to be visible to GitHub Apps where they...

@waltonseymour apologies for the delay on this. There's an [internal check](https://github.com/desktop/dugite/blob/master/lib/git-process.ts#L129) that if we don't find Git at the expected path, but of course we don't actually include that path...

> I'm assuming something is wrong with the path to the binary in the renderer process, whether it be webpack or something else. Let me know what error you do...

@gengjiawen this is probably because we explicitly [copy](https://github.com/desktop/desktop/blob/60f90d3805ae417731ca9603e1e30b5956cec156/script/build#L205) the package into the output folder before packaging, and then [set the environment variable](https://github.com/desktop/desktop/blob/818e6935cbf863137aa4b259e3b19d38ee629b96/app/src/ui/index.tsx#L40) in the renderer process. For other setups or...

@gengjiawen your repro is related to ASAR being enabled by default when you invoke `electron-builder` - there are a number of [limitations](https://electron.atom.io/docs/tutorial/application-packaging/#limitations-of-the-node-api) which this introduces on the Node API, and...

> The `Error: spawn ENOTDIR` error occured, I think it's because `__dirname` is inside asar. Electron will unpack the necessary contents from the ASAR archive that it thinks it needs...

> I don't quite follow you, If i replace the `__dirname` with a valid dir, I get the `error fatal: Unable to find remote helper for 'https'`, not `ERROR spawn...

Looks like the ASAR unpacking is ignoring shortcuts. This is from the unpacked `dugite-native` archive: And this is from the unpacked `git-core` directory inside `asar.app.unpacked`: ``` dugite-vue.app/Contents/Resources/app.asar.unpacked/node_modules/dugite/git/libexec/git-core: ... -rw-r--r-- 1...

@gengjiawen cool - sounds like this should all just work if we can tell the ASAR packing to also include shortcuts!

> I see, it's not bunding git-remote-https. Precisely. Digging into whether this is a limitation of `asar`, or whether `electron-builder` is just ignoring these (for whatever reason).