Michael Sherman

icon indicating an email [email protected]

icon company Toyota Research Institute icon location Los Altos, California, USA

Results 398 comments of Michael Sherman

Fix clang warnings in FactorSVD.

Looks to me that `FactorLU` and `FactorQTZ` are done correctly, while `Eigen` and `FactorSVD` are wrong (in the current code I mean). We should add missing consts to the methods...

Fix clang warnings in FactorSVD.

> is FactorSVDRepBase part of the user interface? No.

Add Constraint::PrescribedVelocity

Is this PR still active?

getThisExecutablePath() should check for errors

This needs to be debugged on FreeBSD, which is not one of Simbody's supported platforms so someone who uses FreeBSD will have to do it (@yurivict, that may be you!)....

getThisExecutablePath() should check for errors

Yikes -- definitely a bug!

getThisExecutablePath() should check for errors

Although #672 fixed the originally-reported problem here, I have retitled this issue for the error-checking bug and will leave it open.

error: 'class SimTK::ContactTrackerSubsystem' has no member named 'getContactSurfaceIndex';

Odd. There certainly is a method `getContactSurfaceIndex()` [here](https://github.com/simbody/simbody/blob/master/Simbody/include/simbody/internal/ContactTrackerSubsystem.h#L205) and that is just 8 lines above the `getContactSurface()` method the compiler is suggesting. I wonder if you have a damaged or...

Use CMake's ${CMAKE_CURRENT_SOURCE_DIR} instead

I'm unclear about what is being proposed here. Is there a change needed to Simbody or is this for people who want to use Simbody? Should there be a documentation...

Use CMake's ${CMAKE_CURRENT_SOURCE_DIR} instead

Thanks -- very helpful! And your English seems perfect. One minor clarification: it's "Simbody" without the capital "B".

Use CMake's ${CMAKE_CURRENT_SOURCE_DIR} instead

And then submit a PR back to the master branch? Great idea! One difficulty with major changes to the build scripts is that they must be retested carefully on all...