Michael Sherman

Results 398 comments of Michael Sherman

Sweet! Thanks. Want to submit a PR and earn eternal fame on the contributors list?

Hi, Jason -- your PR #691 to fix this is ready to merge except for one request for a comment. Can you add that so we can merge it? If...

Thanks for the great investigation, @MadCatX -- would you like to submit a PR with a fix?

Thanks! Ideally if times==0 it should simply return rather than creating and destroying a task that does nothing. Consider making that a separate case that just returns and then leaving...

Apologies for the delay -- #704 looks good with some minor review comments, PTAL.

I notice these are the "static" versions of the tests (i.e. linked with static libraries). I don't think we have tried those for a long time. Do you get the...

It's disturbing to me that there would be _any_ difference between the static and shared-library builds.

Thanks, Daniel! Looks like there may be a merge conflict, or maybe you just need to merge master into your branch. The automated build failed with the error below. the...

BTW, if you look on the conversation page for a PR you can see the Travis CI build status -- it gets built when you first submit the PR and...