sherlockdoyle

Results 8 comments of sherlockdoyle

Possible solution: Allow `skia.PathEffect.DashInfo()` to be initialized with a count, which will allocate the required memory for `fIntervals`.

Draw into a picture (`skia.Picture`/`SkPicture`).

Think of a picture as a separate surface (like a normal image/screen). Anything you draw with `canvas1` will use its very own coordinate system. Then think of it as a...

@kyamagu What was the philosophy behind these setXYZ functions? Why are they copying their parameters (with serialize and deserialize)? From what I understand, we can fix this bug by removing...

> Thanks for the great proof-of-concept. Certainly building a matplotlib backend is an interesting idea. Unfortunately, I do not have any capacity in developing / maintaining additional functionality beyond what...

The correct way to call `asADash` is this ```cpp SkPathEffect::DashInfo info; SkPathEffect::DashType type = pathEffect.asADash(&info); // get fCount if (info.fCount) { info.fIntervals = new SkScalar[info.fCount]; // allocate memory self.asADash(&info); //...

`asADash` already checks `fIntervals == nullptr` internally. In C++, `fIntervals` is supposed to be owned by the user. They are supposed to allocate and free the memory. In Python, at...

Yes, that will work too. See https://github.com/sherlockdoyle/Animator/blob/ebd5e93f3f47cce5b841425fabed1c1afb4bb41b/skia/PathEffect.cpp#L105 The data in Python lists are not laid out in a way that's compatible with a C++ array. As I said, you will...