sherlock-lin

Results 7 comments of sherlock-lin

> Hi @sherlock-lin Please link this PR to target ISSUE Hi @mxsm I have linked target ISSUE

> Overall looks good, can we use four indents in new code of `bookkeeper-server/src/test/java/org/apache/bookkeeper/client/HandleFailuresTest.java`? sure😊

@shoothzj Hi shoothzj, I'm very interested in this job, can I have it processed?

> @sherlock-lin Sure, go ahead, I think we'd better change less than 15 files in one Pull Reuqest. Okay, I'll do it in small batches.

> OpenRewrite contains support for Junit4 to Junit5 migration. It's probably worth using it to assist in the migration. https://docs.openrewrite.org/running-recipes/popular-recipe-guides/migrate-from-junit-4-to-junit-5 > > I'd also recommend using AssertJ for more complex...

@shoothzj please reopen this issue,since I configured Fix #4322 in the previous mr causing it to be closed incorrectly