Jake Goulding

Results 616 comments of Jake Goulding

Having said that, the use of features could prove to be *very* annoying in such a case. The user wants to set this configuration and then much lower-level code would...

Plenty of crates Use build scripts to generate source code, so I don’t know why this would be a problem.

> lib::num::flt2dec::strategy In our own libcore, we've disabled a lot of this code because it's simply too big. This may not be an *extra* blocker from moving to LLVM 6.

> It tries to return a struct with the fields initialized to zero? That seems like it to me! > This doesn't sound to hard to fix. Awesome!

Can you narrow down what exactly the problem is? Is it just that the condition (`if (e > 1)`) has been removed? Is it that the call to `std::reverse` is...

> as ignorant as I am about LLVM Welcome to the club! 😸

@brainlag to double-check: should **both** [this patch](https://github.com/avr-rust/rust/issues/92#issuecomment-373225125) and [this patch](https://github.com/avr-rust/rust/issues/92#issuecomment-374778234) be applied, or does the second one replace the first?

> Only the second one. Cool. I've crossed out the first one to help in the future.

Here's a reduced testcase from [the updated codebase](https://github.com/avr-rust/rust/pull/137): ```llvm ; ModuleID = 'bugpoint-reduced-simplified.bc' source_filename = "core.37hoedwx-cgu.0" target datalayout = "e-P1-p:16:8-i8:8-i16:8-i32:8-i64:8-f32:8-f64:8-n8-a:8" target triple = "avr-unknown-unknown" %num__flt2dec__Part = type { [0 x...

> Can you try also with this patch Yes, applying that does seem to improve the situation. I'll try again with libcore.