Jake Goulding
Jake Goulding
Ok, I pinged some smart compiler devs: **Nikita Popov** > From a quick search, we have https://github.com/rust-lang/rust/blob/49d139c64b69ec5289f9f81db885ecfc2c7a8366/src/librustc_codegen_llvm/abi.rs#L365 and https://github.com/rust-lang/rust/blob/49d139c64b69ec5289f9f81db885ecfc2c7a8366/src/librustc_codegen_llvm/type_.rs#L308. >Possibly the code in https://github.com/rust-lang/rust/blob/da9ebc828c982d2ed49396886da85011e1b0a6c0/src/librustc_codegen_ssa/mir/rvalue.rs#L167 is relevant, it deals a lot...
eddyb walked me through something that seems to at least compile; I've hit other issues with async/await so my program as a whole doesn't link, but might be worth someone...
An updated version of the previous patch ```diff diff --git a/src/librustc_codegen_llvm/common.rs b/src/librustc_codegen_llvm/common.rs index a5cda5949ee..fdbf222549e 100644 --- a/src/librustc_codegen_llvm/common.rs +++ b/src/librustc_codegen_llvm/common.rs @@ -244,6 +244,8 @@ impl ConstMethods for CodegenCx { } value...
I actually expect that your changes, being more thorough, may have the possibility of making this diff obsolete (fingers crossed)
> other failures down the line" - were they related to function pointer casts? I _believe_ so, but it was a year ago, so my memory is fuzzy. IIRC, I...
And someone has a [proposed fix for the glue](https://reviews.llvm.org/D53106)
We've recently upgraded to LLVM 8 🎉 I'm going to close any bug that is reported against an older version of LLVM. If you are still having this issue with...
From #27: >> Will targeting trunk cause troubles to try and get the patches into Rust's LLVM? > > I'm not entirely sure to be honest. I'd really like it...
``` 09:51 < acrichto> shep: we don't really have a policy around llvm upgrades right now 09:51 < acrichto> but historically 09:51 < acrichto> a) backports of merged patches are...