Jake Goulding

Seconding the concerns about documenting unsafety. It would be good to document what the caller needs to ensure to keep the program memory safe.

Oh, wow, I'm sorry that this totally dropped off my radar! I think the idea has merit, but I think I would suggest a different implementation. Right now, we have...

After musing on it for a while I wonder if we could change `ByteSubstring` to be generic with `T: AsRef`.

> Sorry for the late response i think you’ve got a few months longer before you need to start apologizing for anything like that 😅

I did [one force-push](https://github.com/shepmaster/jetscii/compare/5ab19e61f852fbc97a3c36a5474d74f426f46282..4c42031a5d78e9ab2559a0feb8fcc5729ae9efad) to tidy up some formatting things, and a [second force-push](https://github.com/shepmaster/jetscii/compare/4c42031a5d78e9ab2559a0feb8fcc5729ae9efad..12486660ca9342dea395cf86d3dc9bd4cf9e3608) to rebase on the current main branch (which has some soundness fixes). Overall, things seem reasonable,...

I don't understand exactly _how_, but the benchmarks all show a marked **decrease** in speed with this branch. That's even including the benchmarks for the standard library versions, which obviously...

> might have backward-incompatible type definition Yeah, I think that this change will warrant a new semver-incompatible version to be released; that's not a big deal IMO. > there is...

Thanks! I made some changes (and re-enabled CI in the repo). If you are good with the commit, feel free to re-sign it and force-push it.

> Do you need to build/run stuff on embedded hardware or can it run on a x86_64 machine? (not too familiar with the embedded world, sorry!) If everything can be...

> * I have never seen this break before but you may also want to exercise register allocation. Hahahaha. I think this has been *the* single most difficult part of...