Joel Stanley

Results 83 comments of Joel Stanley

Would this work? ``` From 33947245ccc71d19b8ec1ffb8be1880459521da6 Mon Sep 17 00:00:00 2001 From: Joel Stanley Date: Thu, 23 Apr 2020 08:32:01 +0930 Subject: [PATCH] cflags: Avoid -mabi=elfv1 for old tools IBM...

A proposed fix. Note that __isMultiprocSupported doesn't follow the pattern of the first two. ``` diff --git a/src/lib/utilmisc.C b/src/lib/utilmisc.C index b3ca1ac04c53..85665c824487 100644 --- a/src/lib/utilmisc.C +++ b/src/lib/utilmisc.C @@ -28,8 +28,7 @@...

Would it be possible for the distros to set this by default when installing on a Power machine?

That's generally the opposite of what you should be doing, for this very reason.

https://google.github.io/styleguide/cppguide.html#Names_and_Order_of_Includes

This happens when the lpc devices are probed in a specific order. They can enable the LPC IRQ before a handler is registered. This is the same bug as https://github.com/openbmc/linux/issues/130...

``` [ 100.791905] [drm:drm_atomic_state_init] Allocated atomic state (ptrval) [ 100.791983] [drm:drm_atomic_get_plane_state] Added [PLANE:29:plane-0] (ptrval) state to (ptrval) [ 100.792055] [drm:drm_atomic_get_crtc_state] Added [CRTC:30:crtc-0] (ptrval) state to (ptrval) [ 100.792162] [drm:drm_atomic_set_mode_for_crtc] Set...

``` 0) | drm_atomic_helper_commit_planes() { 0) | drm_simple_kms_plane_atomic_update() { 0) | aspeed_gfx_pipe_update() { 0) | drm_crtc_vblank_get() { 0) | drm_vblank_get() { 0) | drm_vblank_enable() { 0) 1.252 us | drm_crtc_from_index();...

[drm-trace.txt](https://github.com/openbmc/linux/files/1913951/drm-trace.txt)