culvert
culvert copied to clipboard
amboar
devmem: Reorder headers
Convention is to include system headers first, and local ones last. This resolves a build issue on centos7:
cc -Isrc/culvert.p -Isrc -I../src -I../src/arch/x86_64 -Isrc/devicetree -flto -DNDEBUG -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -std=gnu99 -O2 -g -MD -MQ src/culvert.p/bridge_devmem.c.o -MF src/culvert.p/bridge_devmem.c.o.d -o src/culvert.p/bridge_devmem.c.o -c ../src/bridge/devmem.c In file included from /usr/include/fcntl.h:77:0, from ../src/bridge/devmem.c:19: /usr/include/bits/stat.h:106:31: error: expected identifier or '(' before '[' token __syscall_slong_t __unused[3]; ^
Hmm, let me poke at this. I tend to order local includes before system includes so the local headers can adjust the behaviour of system headers as necessary. The fact that re-ordering fixes it feels a bit off?
That's generally the opposite of what you should be doing, for this very reason.
https://google.github.io/styleguide/cppguide.html#Names_and_Order_of_Includes