Joel Stanley
Joel Stanley
``` [ 80.570648] [drm:drm_atomic_state_init] Allocated atomic state (ptrval) [ 80.570726] [drm:drm_atomic_get_plane_state] Added [PLANE:29:plane-0] (ptrval) state to (ptrval) [ 80.570803] [drm:drm_atomic_get_crtc_state] Added [CRTC:30:crtc-0] (ptrval) state to (ptrval) [ 80.570914] [drm:drm_atomic_set_mode_for_crtc] Set...
Fix was to move the vblank_enable callback from the `struct drm_device` to the ctrc. Normal drivers would add it to `struct drm_crtc_funcs`. However, the aspeed_gfx driver is a uses the...
The user I was looking at is __enable_vblank in drivers/gpu/drm/drm_vblank.c: ```c static int __enable_vblank(struct drm_device *dev, unsigned int pipe) { if (drm_core_check_feature(dev, DRIVER_MODESET)) { struct drm_crtc *crtc = drm_crtc_from_index(dev, pipe);...
I think the issue is we calculate `BIT(gate->reset_idx)` unconditnally, outside of the check for `reset_idx >= 0`. Assuming this is the case, the bad value is never used. The code...
``` #1 0x804cf3ec in aspeed_clk_enable (hw=0x97d65b40) at drivers/clk/clk-aspeed.c:214 reg = 2547006412 clk = 4 #2 0x804c1d74 in clk_core_enable (core=0x91d82c00) at drivers/clk/clk.c:881 ret = 0 #3 0x804c6584 in __clk_core_init (core=) at...
I think GFX issue was always present but we never triggered it as no device had a pinmux configuration that disabled the VPO pin. The offending patch results in changes...
Thread where the patch was merged with my initial report of the regression: https://lore.kernel.org/all/CACPK8XfQ=uarsOgJ7LaXqLyGG2vSF-47RkAEV=T2gruapx-yfg@mail.gmail.com/ Proposed patch with review from @amboar https://lore.kernel.org/all/[email protected]/ Qemu patch to add GFX address space. https://lore.kernel.org/all/[email protected]/
v5.17 does not warn. v5.18 does. (Note: when building pre-5.16 kernels with Debian's armhf cross compiler, cherry pick 418ace9992a7647c446ed3186df40cf165b67298) Bisection points to b87cf9118e03d8a83039c88fa348165148f5d487 as the culprit. ``` $ git bisect...
``` # cat /etc/fb.modes mode "800x600-60" # D: 40.00 MHz, H: 37.879 kHz, V: 60.32 Hz geometry 800 600 800 600 8 timings 25000 88 40 23 1 128 4...
I changed the mode to this (in order to match the expected mode by the drm_fb code) and it worked: ``` mode "800x600-60" # D: 40.00 MHz, H: 37.879 kHz,...