Shehan Munasinghe

Results 14 comments of Shehan Munasinghe

Hi @amyeroberts, Thanks for your response. Please note that this is a Work In Progress (WIP) pull request. The changes to the modeling code and the documentation will be reflected...

Hi @amyeroberts , this is now ready for your review.

Hi @amyeroberts , There is one test case failing (_examples_torch_). This happened only after I merged recent changes from the main branch. Could you please help me identify what's causing...

Hi @amyeroberts , I have resolved the issues that were raised during the code review. Please take a look.

Hi @amyeroberts, thanks for your time and effort in reviewing this. This is my first pull request on this repo and I'm glad to hear your constructive comments. I have...

Hi @amyeroberts , I have fixed those issues and pushed the updated code. However, as indicated [here](https://app.circleci.com/pipelines/github/huggingface/transformers/64108/workflows/8a8e0c78-afcd-44ab-9079-393eb6abc14f/jobs/792496?invite=true#step-113-8379) one test is failing, though this has nothing to do with `tests/models/whisper/test_modeling_whisper.py`. `...

> Hi @amyeroberts , I have fixed those issues and pushed the updated code. > > However, as indicated [here](https://app.circleci.com/pipelines/github/huggingface/transformers/64108/workflows/8a8e0c78-afcd-44ab-9079-393eb6abc14f/jobs/792496?invite=true#step-113-8379) one test is failing, though this has nothing to do...

Hi @amyeroberts , thanks for approving this PR. I have updated everything and now I think it can be merged.

Hi @joaocmd , the PyTorch version of SwiftFormer is now merged so you can continue working the TensorFlow version of it.

@amyeroberts please note that this is still a work in progress. I'll let you know when it is ready for your review.