transformers icon indicating copy to clipboard operation
transformers copied to clipboard

[WIP] Add MobileViTv2

Open shehanmunasinghe opened this issue 1 year ago • 1 comments

What does this PR do?

Adds the MobileViTv2 model into transformers library (PS: Work in Progress)

Fixes # (issue)

Before submitting

  • [ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • [x] Did you read the contributor guideline, Pull Request section?
  • [x] Was this discussed/approved via a Github issue or the forum? Please add a link to it if that's the case. https://github.com/huggingface/transformers/issues/22570
  • [x] Did you make sure to update the documentation with your changes? Here are the documentation guidelines, and here are tips on formatting docstrings.
  • [ ] Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag members/contributors who may be interested in your PR.

@amyeroberts

shehanmunasinghe avatar Apr 18 '23 07:04 shehanmunasinghe

@amyeroberts please note that this is still a work in progress. I'll let you know when it is ready for your review.

shehanmunasinghe avatar Apr 29 '23 03:04 shehanmunasinghe

The documentation is not available anymore as the PR was closed or merged.

@amyeroberts , this is now ready for your review.

shehanmunasinghe avatar May 02 '23 14:05 shehanmunasinghe

@amyeroberts , any updates?

shehanmunasinghe avatar May 23 '23 01:05 shehanmunasinghe

Hi @amyeroberts, thanks for your review. I have applied the suggestions and pushed the updated code.

shehanmunasinghe avatar May 24 '23 08:05 shehanmunasinghe

@amyeroberts, thanks for your feedback and I have now applied the suggested changes.

shehanmunasinghe avatar May 30 '23 15:05 shehanmunasinghe