Shashank Kumar

Results 74 comments of Shashank Kumar
trafficstars

Hi @nicolas-raoul do we still want to do this ? I still see Custom Selector not available in Nearby , if yes, then can I work on this ?

> @shashankiitbhu Maybe you can build upon Eric's pull request? There seems to be a lot of conflicts since the Project has changed significantly since then but I'll definitely take...

@nicolas-raoul Added the Enhancement and since the Enhancement was to be made in NearbyParentFragment which was still not migrated to view binding so I also migrated it to view binding...

> I get this crash with this branch, even after deleting the app's data: looking into this issue now

@nicolas-raoul Fixed the crash, Please Review, thanks

@ShashwatKedia no that's not the issue I am trying to report here, if you read the summary again I have mentioned that failing is not the problem, but dialog still...

> However, this is about handling the case when the process is failed, right? Yes

> If you don't mind can I work on this as I was digging it up recently and found the exact solution which is causing the bug and fix? Can...

> @shashankiitbhu Sorry do you still need anything from us? If yes would you mind summarizing or posting a link here? Thanks :-) Actually, as mentioned above I was waiting...

> The issue is not that set wallpaper is failing to set the Image as wallpaper but that it is NOT Informing the user that it has failed and dialog...