Shashank Kumar

Results 75 comments of Shashank Kumar
trafficstars

@kanahia1 no problem, and you didn't bother me at all and thanks for understanding what I was trying to explain here. I am sure there are many other Issues you...

@nicolas-raoul this will greatly enhance the Nearby feature, I am currently working on Nearby, I would love to take this task as well, can I work on this?

> Hey @shashankiitbhu, I think we should work on https://github.com/commons-app/apps-android-commons/issues/4560 first than working on this issue. Otherwise this issue will make things much expensive. Also this issue is now part...

@kanahia1 It's better do both together in a GSOC , I agree that the mentioned task should be done first

Hi @nicolas-raoul , following are covered in the Above PRs (Each PR addresses 1 Package, except the last PR) : app/src/main/java/fr/free/nrw/commons/category/CategoryDetailsActivity.java app/src/main/java/fr/free/nrw/commons/settings/SettingsActivity.java app/src/main/java/fr/free/nrw/commons/contributions/MainActivity.java app/src/main/java/fr/free/nrw/commons/contributions/ContributionsFragment.java app/src/main/java/fr/free/nrw/commons/contributions/ContributionViewHolder.java app/src/main/java/fr/free/nrw/commons/explore/ExploreListRootFragment.java app/src/main/java/fr/free/nrw/commons/explore/ExploreFragment.java app/src/main/java/fr/free/nrw/commons/explore/depictions/WikidataItemDetailsActivity.java app/src/main/java/fr/free/nrw/commons/explore/map/ExploreMapFragment.java app/src/main/java/fr/free/nrw/commons/explore/ExploreMapRootFragment.java...

@neeldoshii I have already pushed PRs covering these two, it would be great if you can choose Files that have not been covered yet (also please look at the list...

> > Hi @nicolas-raoul , following are covered in the Above PRs (Each PR addresses 1 Package, except the last PR) : > > app/src/main/java/fr/free/nrw/commons/category/CategoryDetailsActivity.java app/src/main/java/fr/free/nrw/commons/settings/SettingsActivity.java > > app/src/main/java/fr/free/nrw/commons/contributions/MainActivity.java app/src/main/java/fr/free/nrw/commons/contributions/ContributionsFragment.java...

@kanahia1 Sure, I am already working on the media package (almost done with it) so you can start on others that are left like campaigns Also Review Package in Progress...

@kanahia1 These are still left and you can work on them if you want : app/src/main/java/fr/free/nrw/commons/notification/NotificationActivity.java app/src/main/java/fr/free/nrw/commons/nearby/fragments/NearbyParentFragment.java app/src/main/java/fr/free/nrw/commons/campaigns/CampaignView.java I hope nothing is missed here 🥲

> @shashankiitbhu Please squash your commits to one. Done, everything is in "Squashed Commits"