apps-android-commons icon indicating copy to clipboard operation
apps-android-commons copied to clipboard

Published 20 hours ago • verified publisher icon commons-app

Make custom image selector available from Nearby

Open Ayan-10 opened this issue 4 years ago • 13 comments
trafficstars

Summary:

In the current state of the app, custom image selector is only available from contributions fragment. We also upload images from Nearby. What about making the custom image selector available from Nearby too ( If that has no disadvantages).

Ayan-10 avatar Sep 05 '21 14:09 Ayan-10

@Ayan-10 can I work on this issue? think this function is pretty beneficial to the whole app Thanks

Eric-peng111 avatar Oct 19 '22 13:10 Eric-peng111

I think @nicolas-raoul can help you with that.

Ayan-10 avatar Oct 20 '22 12:10 Ayan-10

@nicolas-raoul Can I please take this issue ? Thanks

Eric-peng111 avatar Oct 21 '22 05:10 Eric-peng111

Hi @Eric-peng111 Would you mind working on bugs first per https://github.com/commons-app/commons-app-documentation/blob/master/android/Volunteers-welcome!.md ? Thanks a lot! 🙂

nicolas-raoul avatar Oct 23 '22 02:10 nicolas-raoul

@nicolas-raoul Thanks for replying I'd like to take another first issue or bug as I am new to this project However, I already fixed about 90% of the issue as this: image

is it possible to let me do this at first ? Sorry I did not know this policy.

Eric-peng111 avatar Oct 23 '22 03:10 Eric-peng111

Hard question 😱 OK for this time exceptionnally, but please keep in mind that it might take a very long time before we review it. Thanks for your understanding! 🙂

You can of course also work on bugs while review is pending.

nicolas-raoul avatar Oct 23 '22 09:10 nicolas-raoul

Thanks for letting me do this issue @Ayan-10 @nicolas-raoul can u assign this issue to me at this point?

Eric-peng111 avatar Oct 24 '22 04:10 Eric-peng111

Hi @nicolas-raoul @Ayan-10 image

I think I done this issue since I tested by debug, so I submitted the first PR to this issue, pls have a check when u have time Let me know if any problem but No need to rush since you said gonna take time to review Thanks

Eric-peng111 avatar Oct 24 '22 04:10 Eric-peng111

Hi @nicolas-raoul do we still want to do this ? I still see Custom Selector not available in Nearby , if yes, then can I work on this ?

shashankiitbhu avatar Mar 25 '24 09:03 shashankiitbhu

Yes thanks! 🙂

nicolas-raoul avatar Mar 25 '24 10:03 nicolas-raoul

@shashankiitbhu Maybe you can build upon Eric's pull request?

nicolas-raoul avatar Mar 25 '24 10:03 nicolas-raoul

@shashankiitbhu Maybe you can build upon Eric's pull request?

There seems to be a lot of conflicts since the Project has changed significantly since then but I'll definitely take a look at it.

shashankiitbhu avatar Mar 25 '24 10:03 shashankiitbhu

@nicolas-raoul Added the Enhancement and since the Enhancement was to be made in NearbyParentFragment which was still not migrated to view binding so I also migrated it to view binding in the same PR so that it's easier to test , Please Review

shashankiitbhu avatar Mar 25 '24 20:03 shashankiitbhu