shartte

Results 323 comments of shartte

Generalised simulation-execution failure with all P2P modules

Hm. I might actually have misread your issue report. Are you saying it is *not* performing simulate/execute on the same output?

Generalised simulation-execution failure with all P2P modules

I'll reopen until I can investigate that - if I understand you correctly - the simulate/execute work on different outputs.

Generalised simulation-execution failure with all P2P modules

@Vectrobe The outputs are stored in a linked hash multimap, so should adhere to order. But funnily enough, especially for the Item P2P I think we're implementing that unsound behavior...

Add an easy toggle for mixin/mixinextras in vanilla mode

Which version would it include? MDG itself doesn't even know directly about Mixin/MixinExtras in the NeoForge-mode :-P

Add an easy toggle for mixin/mixinextras in vanilla mode

> > Which version would it include? > > MDG itself doesn't even know directly about Mixin/MixinExtras in the NeoForge-mode :-P > > What's it do when in neoforge mode?...

Fix: no modid is logged when "Failed to validate feature bounds"

Thanks for your PR, but the logging should be based on the mod-loading issues that are created a few lines below. They have a suitable `toString()` method meaning they can...

Fix: no modid is logged when "Failed to validate feature bounds"

> > Thanks for your PR, but the logging should be based on the mod-loading issues that are created a few lines below. They have a suitable `toString()` method meaning...

Bult-in early display stuff is not reusable

I am against making the internals of earlydisplay an API.

Bult-in early display stuff is not reusable

p.s.: You have not actually specified *why* you would want to make a full derivative of earlydisplay. Can you clarify why that is necessary?

add colored output to the terminal using `teminal.jline`

I honestly do not want to set such an arbitrary property in the MDKs.