shartte
shartte
@cnauroth I am actually running into the same issue and would probably propose a different fix. The issue I see is that there are references to the dropwizard metrics classes...
w.r.t. the breaking-change label: We're changing what our public API methods can return by implementing this change. Some middleware might have relied on mod-ids being simple Java identifiers (i.e. implementing...
> This does not change what any public API methods may return. getModId could have returned a mod ID with dots in it before if you were working with a...
We use ModFile == Java module semantics and Java modules do not allow dashes
Processing Pattern Encoder: Set amount doesn't work if pick block is not the default of middle click
We are not using the pick block binding for handling middle-mouse-clicks in the UI. So something else is actually forwarding that, maybe?
Briefly postponed. We need to check if we use Class.forName correctly in other cases too.
> This seems to me like an overabundance of caution,..... But people seem to run into this so yeah LGTM I've had one user report where they had renamed a...
If possible I'd like to finish the early error screen before we do something like this 🤔 Although I am aware that saying "it'll be ready soon, I promise" isn't...
can you check if those are on a chunk border?
With the release of 1.21.5 imminent, I'll probably not be able to look at this immediately, but will do so later.