Shamser Ahmed

Results 9 comments of Shamser Ahmed

> @shamser is there an equivalent change needed for the elapsed time? Elapsed time is already being recorded to nanosecond accuracy. No changes required for elapsed time. @GordonSmith

> ime_since_epoch()); @ghalliday if there are other places that would benefit from more nano-second accuracy timestamps, I'd prefer to make the the suggested change in a separate PR (https://hpccsystems.atlassian.net/browse/HPCC-31833). As...

> wudetails @ghalliday I have created a Jira for this: https://hpccsystems.atlassian.net/browse/HPCC-32127. I am trying to work out how ECL Watch could specify the required information for the timeline. One option...

The following PRs must be merged before this one: https://github.com/hpcc-systems/HPCC-Platform/pull/18538 and https://github.com/hpcc-systems/HPCC-Platform/pull/18547 .

> @shamser - can you remind me why this isn't/can't be implemented via the StatisticsAggregator mechanism? @jakesmith SSTdfuworkunit statistic is updated by fileservices plugin using CLocalWorkunit::setStatistic. To update the aggregates...

The commit message has been updated to explain the change to setStatistic. I believe the change to the filter depth is necessary. Please see comment: https://github.com/hpcc-systems/HPCC-Platform/pull/18358#discussion_r1593708627. @ghalliday

> @shamser - looks fine, but see comment re. offset_t's in CFileSizeTracker Sorry, forgot to push the last batch of changes.

> StSizeInternalTemp @ghalliday If I have understood correctly, shouldn't StSizeInternalTemp be zero at the end of each activity?

> @shamser - please see comments. Some changes made in https://github.com/hpcc-systems/HPCC-Platform/pull/18573 will mean that this PR will need to be updated. I'll update this PR once 18573 is merged. @jakesmith