HPCC-Platform icon indicating copy to clipboard operation
HPCC-Platform copied to clipboard

HPCC-31654 Include DFU WUs in metrics timeline

Open GordonSmith opened this issue 9 months ago • 1 comments

Type of change:

  • [ ] This change is a bug fix (non-breaking change which fixes an issue).
  • [x] This change is a new feature (non-breaking change which adds functionality).
  • [ ] This change improves the code (refactor or other change that does not change the functionality)
  • [ ] This change fixes warnings (the fix does not alter the functionality or the generated code)
  • [ ] This change is a breaking change (fix or feature that will cause existing behavior to change).
  • [ ] This change alters the query API (existing queries will have to be recompiled)

Checklist:

  • [ ] My code follows the code style of this project.
    • [ ] My code does not create any new warnings from compiler, build system, or lint.
  • [x] The commit message is properly formatted and free of typos.
    • [ ] The commit message title makes sense in a changelog, by itself.
    • [x] The commit is signed.
  • [ ] My change requires a change to the documentation.
    • [ ] I have updated the documentation accordingly, or...
    • [ ] I have created a JIRA ticket to update the documentation.
    • [ ] Any new interfaces or exported functions are appropriately commented.
  • [x] I have read the CONTRIBUTORS document.
  • [x] The change has been fully tested:
    • [ ] I have added tests to cover my changes.
    • [ ] All new and existing tests passed.
    • [ ] I have checked that this change does not introduce memory leaks.
    • [ ] I have used Valgrind or similar tools to check for potential issues.
  • [x] I have given due consideration to all of the following potential concerns:
    • [ ] Scalability
    • [ ] Performance
    • [ ] Security
    • [ ] Thread-safety
    • [ ] Cloud-compatibility
    • [ ] Premature optimization
    • [ ] Existing deployed queries will not be broken
    • [ ] This change fixes the problem, not just the symptom
    • [x] The target branch of this pull request is appropriate for such a change.
  • [x] There are no similar instances of the same problem that should be addressed
    • [ ] I have addressed them here
    • [ ] I have raised JIRA issues to address them separately
  • [x] This is a user interface / front-end modification
    • [ ] I have tested my changes in multiple modern browsers
    • [x] The component(s) render as expected

Smoketest:

  • [ ] Send notifications about my Pull Request position in Smoketest queue.
  • [ ] Test my draft Pull Request.

Testing:

GordonSmith avatar May 02 '24 15:05 GordonSmith

Jira Issue: https://hpccsystems.atlassian.net//browse/HPCC-31654

Jirabot Action Result: Workflow Transition: Merge Pending Updated PR

github-actions[bot] avatar May 02 '24 15:05 github-actions[bot]

wudetails @ghalliday I have created a Jira for this: https://hpccsystems.atlassian.net/browse/HPCC-32127. I am trying to work out how ECL Watch could specify the required information for the timeline. One option is to have the request specify the scope types (Workflow, graph, subgraph, dfu) and not the depth. The iterator works the correct depth for the different scope types. Another option is to create a new "time elapsed" attribute for the containing operations scope, so that depth 3 may be used. What do you think?

shamser avatar Jun 24 '24 12:06 shamser

I believe this PR will also fix this issue: https://github.com/hpcc-systems/HPCC-Platform/pull/18854

GordonSmith avatar Jul 05 '24 12:07 GordonSmith

Closing in favor of: https://github.com/hpcc-systems/HPCC-Platform/pull/18854

GordonSmith avatar Jul 05 '24 12:07 GordonSmith