Shashwat Vangani

Results 241 comments of Shashwat Vangani

**Update:** From [pr3177.16](https://github.com/shaavan/rust-lightning/commits/pr3177.16) to [pr3177.17](https://github.com/shaavan/rust-lightning/commits/pr3177.17) ([diff](https://github.com/shaavan/rust-lightning/compare/pr3177.16..pr3177.17)): Addressed @jkczyz comment Changes: 1. Update pad_to_length functions to use match instead of unwrap() 2. Update the test to have non-zero context, to ensure...

**Update:** From [pr3177.17](https://github.com/shaavan/rust-lightning/commits/pr3177.17) to [pr3177.18](https://github.com/shaavan/rust-lightning/commits/pr3177.18) ([diff](https://github.com/shaavan/rust-lightning/compare/pr3177.17..pr3177.18)): Addressed @jkczyz comment Changes: 1. Reverted visibility changes for `BlindedPath` in `BlindedMessagePath`.

**Update:** From [pr3177.18](https://github.com/shaavan/rust-lightning/commits/pr3177.18) to [pr3177.19](https://github.com/shaavan/rust-lightning/commits/pr3177.19) ([diff](https://github.com/shaavan/rust-lightning/compare/pr3177.18..pr3177.19)): Changes: 1. Rebase on main to resolve merge conflicts.

**Update:** From [pr3177.19](https://github.com/shaavan/rust-lightning/commits/pr3177.19) to [pr3177.20](https://github.com/shaavan/rust-lightning/commits/pr3177.20) ([diff](https://github.com/shaavan/rust-lightning/compare/pr3177.19..pr3177.20)): Addressed feedback from @TheBlueMatt and @jkczyz. **Changes:** 1. Simplified the padding approach by removing padding as a field from `{Forward, Receive}` TLVs. 2. Introduced...

**Update:** From [pr3177.20](https://github.com/shaavan/rust-lightning/commits/pr3177.20) to [pr3177.21](https://github.com/shaavan/rust-lightning/commits/pr3177.21) ([diff](https://github.com/shaavan/rust-lightning/compare/pr3177.20..pr3177.21)): Addressed @TheBlueMatt comment Changes: 1. Update code so that we would not be padding the compact blinded paths. 2. Introduce a test to check...

**Update:** From [pr3177.21](https://github.com/shaavan/rust-lightning/commits/pr3177.21) to [pr3177.22](https://github.com/shaavan/rust-lightning/commits/pr3177.22) ([diff](https://github.com/shaavan/rust-lightning/compare/pr3177.21..pr3177.22)): Changes: 1. Rebase on main to resolve merge conflicts.

**Update:** From [pr3177.22](https://github.com/shaavan/rust-lightning/commits/pr3177.22) to [pr3177.23](https://github.com/shaavan/rust-lightning/commits/pr3177.23) ([diff](https://github.com/shaavan/rust-lightning/compare/pr3177.22..pr3177.23)): Changes: ### Fixed the Padding approach. 1. Previous version: Packets were padded individually based on compact forward TLVs. This incorrectly led to padding ReceiveTlvs,...

**Update:** From [pr3177.23](https://github.com/shaavan/rust-lightning/commits/pr3177.23) to [pr3177.24](https://github.com/shaavan/rust-lightning/commits/pr3177.24) ([diff](https://github.com/shaavan/rust-lightning/compare/pr3177.23..pr3177.24)): Addressed @jkczyz comments Changes: 1. Fix typo, and visibility.

**Update:** From [pr3177.24](https://github.com/shaavan/rust-lightning/commits/pr3177.24) to [pr3177.25](https://github.com/shaavan/rust-lightning/commits/pr3177.25) ([diff](https://github.com/shaavan/rust-lightning/compare/pr3177.24..pr3177.25)): Addressed comments from @jkczyz and @TheBlueMatt. **Changes:** 1. Introduced different padding round-off for message and payment TLVs. 2. Padding sizes were chosen based on...

**Update:** From [pr3177.25](https://github.com/shaavan/rust-lightning/commits/pr3177.25) to [pr3177.26](https://github.com/shaavan/rust-lightning/commits/pr3177.26) ([diff](https://github.com/shaavan/rust-lightning/compare/pr3177.25..pr3177.26)): Addressed @jkczyz comments Changes: 1. Update the Padding for Payment Tlvs to 35, according to [this](https://github.com/lightningdevkit/rust-lightning/pull/3177#discussion_r1822368828) discussion.