Shashwat Vangani

Results 241 comments of Shashwat Vangani

**Updated from** [pr2380.02](https://github.com/shaavan/rust-lightning/commits/pr2830.02) to [pr2830.03](https://github.com/shaavan/rust-lightning/commits/pr2830.03) ([diff](https://github.com/shaavan/rust-lightning/compare/pr2830.02..pr2830.03)): Addressed @TheBlueMatt comments ### Changes: - **Rebase** on main branch to resolve conflicts. - **Introduce custom TLVs** as a simple Option. - **Expose an...

**Updated from** [pr2380.03](https://github.com/shaavan/rust-lightning/commits/pr2830.03) to [pr2830.04](https://github.com/shaavan/rust-lightning/commits/pr2830.04) ([diff](https://github.com/shaavan/rust-lightning/compare/pr2830.03..pr2830.04)): Changes: 1. Introduce the sender_custom_tlvs & user_custom_tlvs distinction. 2. Introduce custom_tlvs in `payment::ReceiveTlvs`

**Updated from** [pr2380.04](https://github.com/shaavan/rust-lightning/commits/pr2830.04) to [pr2830.05](https://github.com/shaavan/rust-lightning/commits/pr2830.05) ([diff](https://github.com/shaavan/rust-lightning/compare/pr2830.04..pr2830.05)): Changes: 1. Finalise & corrected the approach. 2. Introduced test.

**Updated from** [pr2380.05](https://github.com/shaavan/rust-lightning/commits/pr2830.05) to [pr2830.06](https://github.com/shaavan/rust-lightning/commits/pr2830.06) ([diff](https://github.com/shaavan/rust-lightning/compare/pr2830.05..pr2830.06)): Changes: 1. Rebase on main.

**Updated from** [pr2380.06](https://github.com/shaavan/rust-lightning/commits/pr2830.06) to [pr2830.07](https://github.com/shaavan/rust-lightning/commits/pr2830.07) ([diff](https://github.com/shaavan/rust-lightning/compare/pr2830.06..pr2830.07)): Changes: 1. Rebase on main to resolve merge conflicts.

**Updated from** [pr2380.07](https://github.com/shaavan/rust-lightning/commits/pr2830.07) to [pr2830.08](https://github.com/shaavan/rust-lightning/commits/pr2830.08) ([diff](https://github.com/shaavan/rust-lightning/compare/pr2830.07..pr2830.08)): Addressed @jkczyz comments Changes: 1. Updated documentation. 2. Update `create_blinded_path` to take `receive_tlvs` as input. 3. Fix CI.

**Updated from** [pr2380.08](https://github.com/shaavan/rust-lightning/commits/pr2830.08) to [pr2830.09](https://github.com/shaavan/rust-lightning/commits/pr2830.09) ([diff](https://github.com/shaavan/rust-lightning/compare/pr2830.08..pr2830.09)): Addressed @TheBlueMatt comments. Changes: 1. Rename custom_tlvs -> custom_data. 2. Update documentation.

**Updated from** [pr2380.09](https://github.com/shaavan/rust-lightning/commits/pr2830.09) to [pr2830.10](https://github.com/shaavan/rust-lightning/commits/pr2830.10) ([diff](https://github.com/shaavan/rust-lightning/compare/pr2830.09..pr2830.10)): Changes: 1. Rebase on main, to resolve merge conflicts. 2. Fix CI.

**Updated from** [pr2380.10](https://github.com/shaavan/rust-lightning/commits/pr2830.10) to [pr2830.11](https://github.com/shaavan/rust-lightning/commits/pr2830.11) ([diff](https://github.com/shaavan/rust-lightning/compare/pr2830.10..pr2830.11)): Addressed @jkczyz comments **Changes:** 1. Restructure & Split commits to be more atomic. 2. Introduce custom_data for all the handlers.

**Updated from** [pr2380.11](https://github.com/shaavan/rust-lightning/commits/pr2830.11) to [pr2830.12](https://github.com/shaavan/rust-lightning/commits/pr2830.12) ([diff](https://github.com/shaavan/rust-lightning/compare/pr2830.11..pr2830.12)): Changes: 1. Rebase on main to resolve merge conflicts. 2. Change tlv number of every `user_custom_data` to 65541, to keep it consistent through the...