Shashwat Vangani

Results 241 comments of Shashwat Vangani

Updated from [pr3412.01](https://github.com/shaavan/rust-lightning/commits/pr3412.01) to [pr3412.02](https://github.com/shaavan/rust-lightning/commits/pr3412.02) ([diff](https://github.com/shaavan/rust-lightning/compare/pr3412.01..pr3412.02)): Changes: 1. Fix ci 2. Update commit messages

Updated from [pr3412.02](https://github.com/shaavan/rust-lightning/commits/pr3412.02) to [pr3412.03](https://github.com/shaavan/rust-lightning/commits/pr3412.03) ([diff](https://github.com/shaavan/rust-lightning/compare/pr3412.02..pr3412.03)): Addressed @jkczyz comments: Changes: 1. Update & Expand Documentation. 2. Move `dnssec` code in flow.rs 3. Simplified OffersMessageFlow trait parametrisation. 4. Move OffersMessageFlow only...

Updated from [pr3412.03](https://github.com/shaavan/rust-lightning/commits/pr3412.03) to [pr3412.04](https://github.com/shaavan/rust-lightning/commits/pr3412.04) ([diff](https://github.com/shaavan/rust-lightning/compare/pr3412.03..pr3412.04)): Changes: 1. Rebase on main. 2. Fix CI.

**Updated** from [pr3412.04](https://github.com/shaavan/rust-lightning/commits/pr3412.04) to [pr3412.05](https://github.com/shaavan/rust-lightning/commits/pr3412.05) ([diff](https://github.com/shaavan/rust-lightning/compare/pr3412.04..pr3412.05)): Addressed @jkczyz's (offline) comments. ### Changes: 1. Moved the `OffersMessageCommons` trait definition to `flow.rs`, as it is a more logical location for its definition....

**Updated** from [pr3412.05](https://github.com/shaavan/rust-lightning/commits/pr3412.05) to [pr3412.06](https://github.com/shaavan/rust-lightning/commits/pr3412.06) ([diff](https://github.com/shaavan/rust-lightning/compare/pr3412.05..pr3412.06)): Changes: 1. Rebase on main to resolve merge conflicts 2. Fix CI

**Updated** from [pr3412.06](https://github.com/shaavan/rust-lightning/commits/pr3412.06) to [pr3412.07](https://github.com/shaavan/rust-lightning/commits/pr3412.07) ([diff](https://github.com/shaavan/rust-lightning/compare/pr3412.06..pr3412.07)): Addressed @TheBlueMatt comment Changes: 1. Corrected code for `cfg[(async_payments)]` 2. Remove stale todo. [reference](https://github.com/lightningdevkit/rust-lightning/pull/3412#discussion_r1876476418) 3. Fix CI

**Updated** from [pr3412.07](https://github.com/shaavan/rust-lightning/commits/pr3412.07) to [pr3412.08](https://github.com/shaavan/rust-lightning/commits/pr3412.08) ([diff](https://github.com/shaavan/rust-lightning/compare/pr3412.07..pr3412.08)): Changes: 1. Rebase on main, to resolve merge conflicts.

**Updated** from [pr3412.08](https://github.com/shaavan/rust-lightning/commits/pr3412.08) to [pr3412.09](https://github.com/shaavan/rust-lightning/commits/pr3412.09) ([diff](https://github.com/shaavan/rust-lightning/compare/pr3412.08..pr3412.09)): Changes: 1. Introduce `create_blinded_paths` in flow.rs 2. This allows removing additional function from `OffersMessageCommons` trait, and hence simplifying it.

**Updated** from [pr3412.09](https://github.com/shaavan/rust-lightning/commits/pr3412.09) to [pr3412.10](https://github.com/shaavan/rust-lightning/commits/pr3412.10) ([diff](https://github.com/shaavan/rust-lightning/compare/pr3412.09..pr3412.10)): Changes: 1. Rebase on main to resolve merge conflicts.

**Updated** from [pr3412.10](https://github.com/shaavan/rust-lightning/commits/pr3412.10) to [pr3412.11](https://github.com/shaavan/rust-lightning/commits/pr3412.11) ([diff](https://github.com/shaavan/rust-lightning/compare/pr3412.10..pr3412.11)): Changes: 1. Remove redundant send_payment_for_bolt12_invoice function. 2. Revert mistakenly added `accept_mpp_keysend`