Sebastien Guillot
Sebastien Guillot
The `@is_secondary.setter` method of the `HotRegion` class should check that is_secondary is a boolean, and set it to `self`. But the fonction is coded with `is_antiphased`. Is this normal ?...
Currently a wrong atmosphere extension (different than 1, 2, or 3) will default to blackbody (=1) with a warning to the user. This warning may go unnoticed by the user,...
The CustomInstrument classes provided either in the tutorials or the Zenodo can be confusing. I think it could be greatly simplified by allowing the use to load directly from the...
The max/min input and max/min channels may be difficult to adjust as the choice of values can raise errors if some rows or columns of the matrix are filled with...
For example: ``` assert channel_array.shape[0] == self._matrix.shape[0] ``` gives ``` raise ChannelError('Channel numbers must be in a one-dimensional array of positive integers' '(including zero).') ```
All tutorial notebooks redefine the same functions for plotting purpose (`veneer()`, `plot_one_pulse()`, `plot_meshes()`, etc...). There are the same everytime, the notebooks would be easier to digest without those functions. They...
In `ParameterSubspace.py`, the initialisation function outputs `No parameters supplied... empty subspace created`. This message could be clarified. Fro example, in the tutorial notebooks, this message may appear like an error...
In #168, it is discussed that the the strict bounds should be relaxed. But it is important to add a verification that the photosphere bounds defined by the user must...