xpsi icon indicating copy to clipboard operation
xpsi copied to clipboard

Possible bug in HotRegion.py

Open sguillot opened this issue 1 year ago • 7 comments

The @is_secondary.setter method of the HotRegion class should check that is_secondary is a boolean, and set it to self. But the fonction is coded with is_antiphased. Is this normal ?

@is_secondary.setter
def is_secondary(self, is_secondary):
    if not isinstance(is_antiphased, bool):
        raise TypeError('Use a boolean to specify whether or not the '
                        'hot region should be shifted by half a cycle.')
    else:
        self._is_antiphased = is_antiphased

Also, the worst part is that is_antiphased is undefined in this method. see screen capture: capture

Any thought on this ?

sguillot avatar Aug 18 '23 07:08 sguillot