sfield17

When passing an array of times, models require the user to supply something for f_low. Probably the behavior should be one of 1. times (as an np array) 2. dt...

ppBHPT-based models should allow the user to call the uncalibrated model

2

passing a calibrated={True,False} argument should allow for ppBHPT waveforms with or without calibration, similar to: https://github.com/BlackHolePerturbationToolkit/EMRISurrogate/blob/master/emri_sur_load.py#L144

Should add a test to check that the model in gwsurrogate.catalog is the most up-to-date one found on Zenodo.

handle missing modes more gently (from Bitbucket)

1

This is from Richard: - Right now, EvaluateSurrogate accepts 'ell_m', a list of modes to load - Until I look at the surrogate file itself, I don't know what modes...

Common interface for all models (from Bitbucket)

1

A new SurrogateLoad and Evaluator class provides a common interface for all models. All other models should use these. This is a high priority so that the interface is stable...

Using hdf5 training info consistently within gwsurrogate (from Bitbucket)

1

Each surrogate hdf5 file has a param_space group which contains information about the training region -- param names, dimensionality, and min/max value of each parameter. This information is used in...

see model_regression_test and comments therein.

each model should have regression tests for returning modes only returning strain any other special features that need tests? Like faked negative modes sampling at different times

This is for the old API, supported for older models When mode_sum true: t, hp, hc = ... false modes, t, hp, hc = ... Better to consistently make t,...

Pull request #2 (bitbucket) was a bit of a rush job to get the code working. Three key pieces of cleanup work remain: 1) param nudging might be best suited...