Shane F. Carr

Results 402 issues of Shane F. Carr

This package was written before TypeScript was invented, before ES6 was widely available in browsers, and before the latest generation of frameworks like Angular, React, and Vue. It would be...

This PR was automatically created by Snyk using the credentials of a real user.Snyk has created this PR to fix one or more vulnerable packages in the `npm` dependencies of...

The `_onDisconnect` function seems problematic. It is run after any client disconnects, but it cancels file uploads from *all* clients. This is probably a bug. See #110

bug

Upgrading the socket.io dependency in package.json for testing to 2.3 causes the tests to hang. Investigate. Failing test: https://travis-ci.com/github/sffc/socketio-file-upload/builds/168153995 See: https://github.com/sffc/socketio-file-upload/commit/4c4e62df53f435b0411fb8a0461201606b5ec897 ``` X_USE_PHANTOM=1 npm test ```

Part of #4629 I rewrote `select_locales_for_key` and I think it is a lot cleaner and comprehensible now.

Fixes https://github.com/unicode-org/icu4x/issues/4843 Alternatively we could re-enable all the features manually, but that's brittle, and I'd rather use the default features. We should probably check all the other crates, too. In...

For the general Diplomat discussion: https://github.com/rust-diplomat/diplomat/issues/471 In ICU4X: we need to decide on `unicode_bidi` behavior. All remaining `&str` FFIs need to be migrated to DiploamtStr.

A-ffi

If the data isn't present, an error should be returned. It's likely we don't need the payload to be an `Option`.

2.0-breaking

Currently we have zerovec::ule::UnvalidatedStr and zerovec::ule::UnvalidatedChar. For a while, we've been meaning to discuss a more final home and name for these types. There's nothing really zerovec-specific about these types...

A-design
needs-approval
C-zerovec