socketio-file-upload icon indicating copy to clipboard operation
socketio-file-upload copied to clipboard

Published 20 hours ago • verified publisher icon sffc

Socket disconnects may cancel in-progress uploads for other clients

Open sffc opened this issue 3 years ago • 4 comments

The _onDisconnect function seems problematic. It is run after any client disconnects, but it cancels file uploads from all clients. This is probably a bug.

See #110

sffc avatar Aug 01 '21 01:08 sffc

I'm going to try to replicate this bug over the next couple of days.

rfox12 avatar Aug 08 '21 19:08 rfox12

Did you happen to be able to replicate this issue? Since this is blocking #110 which has been stale for a while.

rclankhorst avatar Sep 02 '21 07:09 rclankhorst

I'm sorry, this package has been a trustworthy workhorse; but my organization is moving away from it in favor of a custom Typescript implementation. Hopefully we'll open source it.

rfox12 avatar Sep 10 '21 16:09 rfox12

If you are able to publish your TypeScript library, I would be happy to recommend it as an alternative to this library. The ecosystem has changed a lot since this was written, and I think the next natural step is to have a whole new clean implementation.

sffc avatar Sep 10 '21 19:09 sffc