Shane F. Carr
Shane F. Carr
@aethanyc @makotokato
I really like this design. It seems consistent with what we did with the LeapLinear design: optimize the data structure based on what calendars actually need. Using era codes instead...
While we're here, we should take a look at the encoding of `VariableEras`. That field will make `YearNamesV1` bigger for everyone. A hack-that-isnt-really-so-bad would be to make everyone use a...
It's not super hacky if you think of it as a stringly typed VarVarULE with ":" as the field separator.
Might need to choose a field separator that is always greater than or less than BCP-47 so that sorting works correctly.
Thank you for the contribution! I'll leave comments soon. In the meantime I triggered the continuous integration.
@Manishearth wdyt?
The default is supposed to be atTime. Currently we default to standard, which is wrong.
The "right thing" according to @pedberg-icu is to have this be an option, because there are certain contexts where you might not want the extra inflected word to appear, but...
I think the name is because CLDR calls it "day of week", similar to "day of month" and "day of year" https://unicode.org/reports/tr35/tr35-dates.html#dfst-day But since the type it returns is called...