Shane F. Carr

> _However_, there's a valid discussion to be had whether in the bottom left case `Foo::ULE = Foo` is preferred (with `repr(transparent)` on the `Foo`. This is more annoying to...

I realized that although we can/should reduce the number of impls of `ULE` when they are redundant (struct with public field), we need `VarULE` implemented in order for the type...

> `$ cargo build --release --example date_try_from_fields` Could you add this code to the pull request?

Thank you. Could you make it use `#![no_main]` and `icu_benchmark_macros` as we do in other examples? See here: https://github.com/unicode-org/icu4x/blob/main/components/icu/examples/iso_date_manipulations.rs It removes a lot of standard library code from the binary...

Thanks; can you re-measure the size impact now? When building, I suggest using `--profile release-opt-size`

I mean, what is the size of the example before and after the change to the try_from_fields code? I have a suggestion: please open a separate PR for the example,...

We've spent time making sure that `--profile release-opt-size` gives a reliable measurement of code size, better than `--release`. If you're not seeing an improvement with that profile, it means that...

On main: ``` $ cargo make wasm-wasm-examples $ ls -l wasmpkg/date_try_from_fields.wasm -rwxr-xr-x 1 sffc primarygroup 47052 Dec 9 17:17 wasmpkg/date_try_from_fields.wasm ``` I tried running on this branch, but you need...

I checked out your branch and merged in main locally to get a measurement. ``` $ cargo make wasm-wasm-examples $ ls -l wasmpkg/date_try_from_fields.wasm -rwxr-xr-x 1 sffc primarygroup 59394 Dec 9...

I posted it a few posts above, but you should be able to reproduce it yourself, which you need to do in order to check if your changes improve it...