Steven Fackler

Results 229 comments of Steven Fackler

https://github.com/sfackler/rust-native-tls/issues/27

Windows and old Unix should be able to just dup the socket.

This seems like a question for the serde repository rather than the bytes repository I think?

What do you mean by parent type semantics? Upcasting? You'd probably end up making a separate trait and macro that wraps `foreign_types!`.

It would also be nice to have this option in `cargo upgrade`.

> but that still requires to use `log` internals for module path, file and line It does not: https://doc.rust-lang.org/std/macro.file.html https://doc.rust-lang.org/std/macro.line.html https://doc.rust-lang.org/std/macro.module_path.html

Trace is used often in low-level libraries like hyper and tokio for very verbose logging information that can be useful to diagnose issues.

Adding a log level is a breaking change. The existing levels match slf4j (with the exception of a fatal level for historical reasons).

I think it would make sense to update the "implementing a logger" section of the docs to say that you should provide a constructor for your `Log` impl in addition...

One interesting question is who should control the max log level. Should the `Log` implementation's constructor set it up, or is that the job of whoever's using it?