Steven Fackler comments

Results 229 comments of


Steven Fackler

provide examples

If you have an `OpenSpan` and want to fully transfer it to the other thread, you can use the `detach` and `attach` methods: ```rust let span = my_tracer.next_span() .with_name("background-thingy") .detach();...

provide examples

No, attaching and detaching doesn't discard any state. The only thing it changes is if the OpenSpan acts as a CurrentGuard in addition.

provide examples

Detach consumes the old OpenSpan by value and returns a new one with the span's state.

Cargo should skip rerun-if-changed paths to files in published crate sources

Ah - I've looked into things a bit more - Circle's caching *does* preserve mtimes, but I was only caching ~/.cargo/registry/cache but not ~/.cargo/registry/src. It seems like unifying the special...

wrong backtrace line for .unwrap() if it is on the next line

The backtrace crate just reads out the debuginfo that the compiler places in the binary. That's what needs to change.

Std implementations of PartialOrd are violating the conditions regarding transitivity and symmetry. And the transitivity requirements are i̶m̶p̶o̶s̶s̶i̶b̶l̶e̶ hard to ensure in a multi-crate ecosystem anyways.

Those requirements are for values that are actually comparable.

Std implementations of PartialOrd are violating the conditions regarding transitivity and symmetry. And the transitivity requirements are i̶m̶p̶o̶s̶s̶i̶b̶l̶e̶ hard to ensure in a multi-crate ecosystem anyways.

Ah right - we already changed that language for PartialEq: #81198. We should make the same change here IMO.

Std implementations of PartialOrd are violating the conditions regarding transitivity and symmetry. And the transitivity requirements are i̶m̶p̶o̶s̶s̶i̶b̶l̶e̶ hard to ensure in a multi-crate ecosystem anyways.

In what context are those `PartialEq` implementations actually reasonable?

Std implementations of PartialOrd are violating the conditions regarding transitivity and symmetry. And the transitivity requirements are i̶m̶p̶o̶s̶s̶i̶b̶l̶e̶ hard to ensure in a multi-crate ecosystem anyways.

The documentation states useful properties that code working with partial equality can assume. I don't think it is necessary or even particularly useful to guard against every hypothetically possible malicious...

Add an optional feature for trading lazy evaluation for smaller binary size?

`__private_api_log_lit` can be re-added in a correct manner by using https://doc.rust-lang.org/stable/std/fmt/struct.Arguments.html#method.as_str. The crate would either have to bump its MSRV to 1.52 or do some conditional compilation with a build...