Steven Fackler

Results 229 comments of Steven Fackler

```rust fn req_sub_uri(mut req: Request, uri: Uri) -> Request { *req.uri_mut() = uri; req } ```

It seems like you'd want StatusCode to serialize and deserialize directly from and to the raw number anyway, so it seems like a manual implementation would be easier and avoid...

I agree that it seems reasonable to move forward without waiting on full first-class Typescript support.

I'd lean towards specifying option 3, personally. However, it seems reasonable to have conjure-java continue deviating from that behavior until we can be confident that its current case-conversion behavior isn't...

Yeah, I think it makes sense to limit the unknown variant handling to strings which could actually be valid but unknown variants. That's just an ASCII SCREAMING_SNAKE_CASE check, right?

The same goes for unknown union variant names too, I suppose.

Oh yeah - I meant that we should make sure that unknown union variant names are eligible to be union variant names. The check would be for snakeCase for those...

Er yeah, that >_>

The proposed layout is pretty trivial to support on the Rust side of things as well.

It's not a problem in Rust - we have very low level access to the JSON structure so a null value is distinguishable from a missing one.