Steven Fackler

Results 327 comments of Steven Fackler

JSON is valid YAML, so it works out. I do think it might be nice to switch the manifest from YAML to JSON, though. It's easier to write tooling around...

Alternatively, we could just make the fields public. That would also allow people to move out of them.

I think this just looks like a breaking change to ErrorType turning `fn name()` into a static method and adding a few utility methods.

The issue here is that the `Client` is currently internally responsible for converting all non-2xx responses into `Err`s. If we moved or disabled that we'd be able to allow the...

Yep, though I think it'll take some design work to figure out how it should interact with Conjure's internal retry logic.

On the client side, it'd look like updating https://github.com/palantir/conjure-rust/blob/11fe3acc8229aec537ea939ebfa80f4f52d11c64/conjure-http/src/client.rs#L366-L385 to declare that it accepts SMILE in addition to JSON, and deserializing appropriately. On the server side, we'd probably want to...

The situation is similar on the client side.

The bulk of the work here should involve creating a bunch of compile-fail tests and making sure their diagnostics look reasonable.

We should also add riscv64 to the CI setup.