conjure-rust icon indicating copy to clipboard operation
conjure-rust copied to clipboard

Published 20 hours ago • verified publisher icon palantir

Support SMILE in serializable responses

Open sfackler opened this issue 2 years ago • 2 comments

conjure-serde has a SMILE encoder, but we currently don't use it in conjure-http.

sfackler avatar May 09 '23 20:05 sfackler

Would this just be adding SmileConjureRequestSerializer and SmileConjureResponseDeserializer implementations that can be opted into using? Or would it be like we try to "guess" whether the response is json vs smile, and then use the appropriate deserializer?

TheKeveloper avatar Dec 15 '23 22:12 TheKeveloper

On the client side, it'd look like updating https://github.com/palantir/conjure-rust/blob/11fe3acc8229aec537ea939ebfa80f4f52d11c64/conjure-http/src/client.rs#L366-L385 to declare that it accepts SMILE in addition to JSON, and deserializing appropriately.

On the server side, we'd probably want to use the new server runtime added in #258 to allow configuration of the supported MIME types.

sfackler avatar Jan 02 '24 14:01 sfackler