Steven Fackler

I think the CI may be a bit broken? The s390x and manifest builds seem to never start running.

Build's green!

That seems like a thing you can trivially do yourself with block_in_place and std::fs::File.

It looks like modules produced on Linux do use the file path as debug_file, so this may be a problem in the macOS implementation of minidump-writer? ``` MINIDUMP_MODULE base_of_image =...

This seems pretty reasonable to me I think. We'd probably want to call the image `rustup` rather than `rust` to avoid too much tag confusion.

> If you know the format data you'll be creating must always be valid utf8, then you should use the `fmt::Write` trait. Why?

I think a separate set of types may be preferable to methods, which would avoid having the extra storage overhead of poison tracking.

Regardless of the implementation cost, having a separate type also makes it more clear how the lock is expected to be used through a codebase - you don't need to...

The structure of `Opaque` is designed to prevent mutation through the `*mut` from being UB: https://github.com/sfackler/foreign-types/blob/393f6ab5a5dc66b8a8e2d6d880b1ff80b6a7edc2/foreign-types-shared/src/lib.rs#L14. Even for C APIs that are const-correct, C's notion of constness is distinct enough...

The `&self` is a pointer to UnsafeCell (semantically through a PhantomData). Why is it being tagged as Frozen?