Fung Lam

Inconsistent Behaviour between 1.1.1 and 2.0.1

2

Inconsistent behaviour between 1.1.1 and 2.0.1, on non-Pixel devices, mostly old models. Strange blank area added (child element warp_content vs match_parent ??) - [X] I have searched [existing issues](https://github.com/google/flexbox-layout/issues) and...

Class Signature is different from Volley

2

Compare with Volley (https://android.googlesource.com/platform/frameworks/volley/), a few classes is not in same package. e.g. com.android.volley.AuthFailureError vs com.android.volley.error.AuthFailureError That breaks the compatibility with Volley, which should be a subset of VolleyPlus.

Note: This issue tracker is for reporting bugs in the Android Reference Design only. **Describe the bug** The build scripts works on Linux, but not working on Windows **To Reproduce**...

In the `build.gradle` in different modules ``` testImplementation 'com.android.support.test.espresso:espresso-core:3.0.2' testImplementation 'com.android.support.test:runner:1.0.2' ``` Support Lib has been discontinued and projects should use AndroidX Test (https://developer.android.com/training/testing/set-up-project) ``` androidTestImplementation 'androidx.test.espresso:espresso-core:3.2.0' androidTestImplementation 'androidx.test:runner:1.2.0' ```...

Double Splash Screen on Android 12

3

https://developer.android.com/about/versions/12/features/splash-screen Android 12 adds the `SplashScreen` API, which enables a new app launch animation for all apps. However, Social Distancing app already implemented a custom Splash Screen. Which caused double...

Removing network security config which has no use

5

the following network security config has no use and should be removed ``` secure.example.com ```

Field requires API level 24, but the min SDK level is 23

1

https://github.com/ailabstw/social-distancing-android/blob/8e4e761dc681a0a71a48c609f58c8b199c41c84f/SocialDistance/src/main/java/tw/gov/cdc/exposurenotifications/nearby/NotificationHelper.kt#L181 https://github.com/ailabstw/social-distancing-android/blob/8e4e761dc681a0a71a48c609f58c8b199c41c84f/SocialDistance/src/main/java/tw/gov/cdc/exposurenotifications/nearby/NotificationHelper.kt#L185 `NotificationManager.IMPORTANCE_NONE` and `NotificationManager.IMPORTANCE_DEFAULT` are added in [API level 24](https://developer.android.com/reference/android/app/NotificationManager#IMPORTANCE_DEFAULT).

Setting requestedOrientation to ActivityInfo.SCREEN_ORIENTATION_PORTRAIT may cause incompatibility on large screen devices

1

https://github.com/ailabstw/social-distancing-android/blob/c7179d943bc242a8eca2fd1cc4eda0f62523e7b3/SocialDistance/src/main/java/tw/gov/cdc/exposurenotifications/activity/BaseActivity.kt#L25 Any reason of forcing portrait mode? It is possible that if a foldable device unfold, the screen will be in landscape mode. Ref: https://developer.android.com/guide/topics/ui/foldables

Private property naming convention

3

https://github.com/ailabstw/social-distancing-android/blob/develop/SocialDistance/src/main/java/tw/gov/cdc/exposurenotifications/activity/UploadActivity.kt - Private property name 'SUPPORTED_TEST_TYPES' should not contain underscores in the middle or the end - Private property name 'COMMAS' doesn't match regex '_?[a-z][A-Za-z\d]*' - Private property name 'BASE64'...

Text sizes should use sp as unit, not dp

1

https://github.com/ailabstw/social-distancing-android/blob/8e4e761dc681a0a71a48c609f58c8b199c41c84f/SocialDistance/src/main/res/layout/activity_barcode_scanning.xml#L33 https://github.com/ailabstw/social-distancing-android/blob/8e4e761dc681a0a71a48c609f58c8b199c41c84f/SocialDistance/src/main/res/layout/activity_main.xml#L120 https://github.com/ailabstw/social-distancing-android/blob/8e4e761dc681a0a71a48c609f58c8b199c41c84f/SocialDistance/src/main/res/layout/activity_splash.xml#L36 https://github.com/ailabstw/social-distancing-android/blob/8e4e761dc681a0a71a48c609f58c8b199c41c84f/SocialDistance/src/main/res/layout/activity_splash.xml#L55 https://github.com/ailabstw/social-distancing-android/blob/8e4e761dc681a0a71a48c609f58c8b199c41c84f/SocialDistance/src/main/res/layout/activity_splash.xml#L73