social-distancing-android icon indicating copy to clipboard operation
social-distancing-android copied to clipboard

Setting requestedOrientation to ActivityInfo.SCREEN_ORIENTATION_PORTRAIT may cause incompatibility on large screen devices

Open seventhmoon opened this issue 3 years ago • 1 comments

https://github.com/ailabstw/social-distancing-android/blob/c7179d943bc242a8eca2fd1cc4eda0f62523e7b3/SocialDistance/src/main/java/tw/gov/cdc/exposurenotifications/activity/BaseActivity.kt#L25

Any reason of forcing portrait mode? It is possible that if a foldable device unfold, the screen will be in landscape mode.

Ref: https://developer.android.com/guide/topics/ui/foldables

seventhmoon avatar Jul 21 '21 04:07 seventhmoon

The only reason is we did not have a proper landscape UI design yet. Allowing landscape mode directly will produce bad UI on some pages, and we do not have enough time to test landscape mode in previous versions.

But I think we may provide landscape mode in the future version :D

catcutecat avatar Jul 21 '21 07:07 catcutecat