social-distancing-android icon indicating copy to clipboard operation
social-distancing-android copied to clipboard

Private property naming convention

Open seventhmoon opened this issue 3 years ago • 3 comments

https://github.com/ailabstw/social-distancing-android/blob/develop/SocialDistance/src/main/java/tw/gov/cdc/exposurenotifications/activity/UploadActivity.kt

  • Private property name 'SUPPORTED_TEST_TYPES' should not contain underscores in the middle or the end
  • Private property name 'COMMAS' doesn't match regex '_?[a-z][A-Za-z\d]*'
  • Private property name 'BASE64' doesn't match regex '_?[a-z][A-Za-z\d]*'
  • Private property name 'HASH_ALGO' should not contain underscores in the middle or the end

seventhmoon avatar Jul 20 '21 03:07 seventhmoon

Those names are from the java sample code, and I didn't change the original names. PR is always welcome :D

catcutecat avatar Jul 20 '21 07:07 catcutecat

Do you mean https://github.com/google/exposure-notifications-android/blob/master/app/src/main/java/com/google/android/apps/exposurenotification/keyupload/DiagnosisAttestor.java ?

Those are private static final (seems the auto conversation from Java to Kotlin isn't perfect)

seventhmoon avatar Jul 20 '21 08:07 seventhmoon

Yes, exactly is.

catcutecat avatar Jul 20 '21 13:07 catcutecat