Jiuyang Liu

Results 339 comments of Jiuyang Liu

@SpriteOvO Please use 'Please Merge' label to ask bot merge it. A label is also required.

Reopen it since #3798 only provide a Binding w/o user-level API.

I don't think this will happen in the near future. However Chisel supports embed Parameter embedded as `Property` inside MLIR.

And another required thing might be providing a `Decoupled` and `Valid` equivalent type, and even deprecate the `coerced` one.

> What would an explicit `Aligned` do? Isn't that a no-op? How about provide a semantic: ``` Aligned(Flipped(MyThing())) Aligned(Aligned(MyThing())) ``` Both equal to ``` Aligned(MyThing()) ``` `Aligned` will ignore the...

Basically I think this is a pitfall in chisel type system, in chisel it runtime modify the chisel type when a wire is connect to other wire. Basically I think...

OK this is certainly a bug. Like declaring register or memory inside when block. In the boring utils case, I personally think it should be forbidden.

Just noticed, did we have same issue for `Mem.read`, `Mem.write` in `when` block sometime ago?

FYI, https://github.com/llvm/circt/issues/1561 may also relate to this issue.