Kim Seon Woo
Kim Seon Woo
Removed the `[ISSUE-5741]` prefix in the commit messages.
>Question) what do you think of just combining the two HealthCheckUpdateHandler and adding similar logic as HealthCheckService? Looks better. I don't think we need to split them into different classes....
Hi, @minwoox :) Thanks for the review. I'll take a look
Maybe we can solve this issue in [here](https://github.com/line/armeria/issues/5705) or any following issues after it's solved. 🤔
I love the way the maintainers explain the details of the issue and extra information. Just reading the issues sometimes help me a lot 😄
I've made a [PR](https://github.com/line/armeria/pull/5741) for above issue. It's not fully complete so we may add more ideas on top of the it. 😄
Seems it will work as expected when this [PR](https://github.com/penberg/limbo/pull/293) is merged
May be add insertion test when `CREATE table ...` is supported
Is this PR being actively worked on? 🙏
@krishvishal PR for delete planning has been added to main. Maybe you can make use of it. Btw, is there any docs or code you are referring to when implementing...