Kim Seon Woo
Kim Seon Woo
@ikhoon Just a ping 😄.
I wonder how to close the doors for new request(that client should send), when graceful shutdown is in progress.
Hi @minwoox, please check if I've understood correctly. > I believe we can add a boolean flag closing to the factory and raise an exception if the factory is used....
@minwoox , thank you for the detailed explanation. 👍 > Oops, I realized that we don't have to add a flag. We can just use isClosing() method. I've added cheking...
@minwoox, I always appreciate the clear and concise explanation from you 🙏. I've applied the exception cheking on above mentioned methods.
@minwoox I've added tests to check whether connection draining is working as expected.
>I'm curious, what kind of test failures did you get? Below three tests fails when `DEFAULT_CLIENT_CONNECTION_DRAIN_DURATION_MICROS` is set other than 0. 😓 
@ikhoon It seems like client side `Http2GracefulConnectionShutdownHandler` is sending GOAWAY frames twice - first GO_AWAY frame to signal clients that shutdown is imminent - second GO_AWAY frame to close the...
I think we need to decide what settings the `ServiceOptions` should support. For now, it only supports three settings which are: - requestTimeoutMillis - maxRequestLength - requestAutoAbortDelayMillis
Should we use the name `ServiceOptions` which is used to configure `HttpService`? Because `HttpService` extends `Service` it might be better to use `HttpServiceOptions` for `HttpService` rather than `ServiceOptions`. 🤔