Kim Seon Woo
Kim Seon Woo
>It may be better. Let use HttpServiceOptions for now. Other folks may have different opinions though. I've renamed the class into `HttpServiceOptions`.
There were some conflicts with my origin and upstream, so I'd reset the commits and did a force push 😓
@minwoox What should happen when users specify WebSocket's allowed origins like below? ``` sb.route() .path("/chat") .build(WebSocketService.builder(new CustomWebSocketServiceHandler()) .allowedOrigins(origin -> origin.contains("armeria")) .allowedOrigins("http://line.com") .build()); ``` Should we throw an exception which specifies...
Oh, that's a great point. Let's clear below questions first. > * If it's the former, is it OK to reject the request for non-matching origins even if we responded...
Thank you @minwoox and @jrhee17 for reviewing my old PR. I've applied the comments which are mainly of - Add `requireNonNull` - Use `OR` logic if `allowedOrigins` and `allowedPredicate` is...
@jrhee17 thanks for the review. Seems like I've already signed up the CLA as follows 
@jrhee17, thank you for detailed explanation. I've fixed my authoring email address
Hi, @koppor, shouldn't the consecutive annotations be separated? Does rewrite already provides above feature 🤔 ?
Hi, @fmbenhassine. I wonder if this issue is handled by anyone. If not, may I try on this issue?
@fmbenhassine Thank you! I'll join above discussion.