David Seddon

Results 219 comments of David Seddon

Thanks so much for this, looking forward to reviewing it. Before I merge it I'll want to make sure there are tests - if you have time to do that,...

Cool, stay in touch. If I end up implementing it I'll let you know too.

Hi Nikita, Thanks, as always, for the suggestion! I'm unclear about whether or not self imports are a real problem. How often does this kind of thing actually happen? I'd...

I'm going to close this ticket as it's quite old, and I think that it's best to keep import linter architecture-focused. I think it is probably possible to support this...

Thanks for raising this. The reason it's failing is because, [as per the docs](https://import-linter.readthedocs.io/en/stable/contract_types.html#forbidden-modules), descendants of each module will also be checked. I suppose there's an argument to say that...

Thanks for raising this! The issue here is that, since `astropy` is classified as an external package, it only appears in the graph that Import Linter analyses as a single...

Great! Could this be because there are missing `__init__.py` files in the packages? There is [an open issue](https://github.com/seddonym/import-linter/issues/96) for allowing these, but in the meantime you could just add the...

Hi Łukasz, thanks so much for this. I haven't used Poetry before and will need to carve out some time to understand it before I merge this, but certainly open...

Thanks for the suggestion - yes, I see what you mean. Particularly in this case, it would be much better if this could be expressed in terms of a single...

I agree with @tolomea. This would work for other contract types (but it's not currently implemented for any contract type). There is a workaround, which is to locate both modules...