David Seddon

Results 219 comments of David Seddon

Thank you! I also use Import Linter with pre-commit. To be honest I'm not sure what specific instructions would be needed beyond whatever is documented in pre-commit, along with the...

Thanks for including! To clarify, this ticket is about a general contract that would enforce a convention we use in our internal code base where modules prepended with an underscore...

> I get a huge list of import errors as any import under django.* is listed as an error. Is it possible that the problem might be because a lot...

Interesting idea! So are you thinking this would be a new contract type? One option for this would be to implement it as a [custom contract](https://import-linter.readthedocs.io/en/stable/custom_contract_types.html) to begin with. It...

I agree. While it's technically a breaking change I think the benefit would outweigh the cost. I'm not convinced there are very many developers writing plugins and I'd be relaxed...

> I would be disappointed to find breaking changes turn up in a minor version bump. But then again, [Semantic Versioning Will Not Save You](https://hynek.me/articles/semver-will-not-save-you/). 😄 > Version numbers are...

I've added a pull request that fixes this: https://github.com/chrisglass/django-shop-paypal/pull/12

Thanks for the issue request! I want to dig a bit more into what you're asking for - from what I understand, there are two potential features here. Feature one:...

Thanks Dan - I'll definitely consider this. I also have a feeling that the layer checking algorithm isn't optimal. Out of interest, is your main pain point the duration of...

Thanks for these comments. I don't actually know what takes longer, building the graph or analysing the layers, so a bit of benchmarking would be the next step.