David Seddon
David Seddon
Apologies, I closed this unintentionally. Reopening.
So to summarize, we could have an API something like this: ``` graph = grimp.build_graph('mypackage', include_external_packages=True, exclude_stdlib=True) ``` And for completeness, possibly this would raise an exception: ``` graph =...
Thanks for raising the issue. 😄 You're right, currently Grimp only treats packages as namespace packages - [it explicitly checks that it's a package rather than a module](https://github.com/seddonym/grimp/blob/a41e3fb4cb47e17b77b68c25f6ff3fb96ca6c50b/src/grimp/adaptors/packagefinder.py#L28). An even...
> I didn't understand this comment. In my example, the namespace package is top. The single-file module top.a, which causes the problem, is a regular single-file module. Did you mean...
Yes, I think I can live with that dependency, considering it's on its way out. Thank you!
Thanks for the issue! I guess it could be an iterable of dependencies, but equally it could be an iterable of modules. It's a good point, though, that there isn't...
Probably the best way to achieve this is to just use Python's logging module, with certain log levels in mind. Import Linter can then capture and output the appropriate log...
Thanks for the bug report, yes I agree we could do better here. I think we should raise `grimp.exceptions.ModuleNotPresent` in this case, which is already raised from some other methods...
Very exciting! Have left a couple of initial comments, also the tests are failing which would be good to sort out.
Thanks for this, nice idea! My concern with this is that I have been wondering about [moving away from Graphviz as a dependency](https://github.com/seddonym/impulse/issues/15). By adding this to the API we...