impulse icon indicating copy to clipboard operation
impulse copied to clipboard

Support to pass graphviz output format

Open sbrugman opened this issue 1 year ago • 2 comments

PDF is much crisper

Tested locally with:

impulse drawgraph --format pdf [my_package]

png:

pdf:

sbrugman avatar Feb 23 '24 19:02 sbrugman

Thanks for this, nice idea!

My concern with this is that I have been wondering about moving away from Graphviz as a dependency. By adding this to the API we are committing to supporting other file formats.

I'm going to leave this one open for the time being, until I've got a good understanding of whether there are any alternatives to Graphviz.

seddonym avatar Feb 26 '24 10:02 seddonym

To make it more generic you could consider forwarding unknown options to the graph save/build methods: https://click.palletsprojects.com/en/5.x/advanced/#forwarding-unknown-options

This way there is no tight link with graphviz, but still there is the ability for passing arguments.

sbrugman avatar Feb 26 '24 10:02 sbrugman