Sebastian Markbåge
Sebastian Markbåge
The partial set where each object has a known identity is already accomplished by the AbstractObjectValue with a ValuesDomain of more than one value. One such special case is the...
Another detail is that the object gets inlined in the generator so it gets created every iteration.
Found another one: #1574
I think this case is especially bad because you don't even need to use getOwnPropertyDescriptor for this one: ```js var c = __abstract('boolean', 'c'); var y = __abstract({foo:1}, 'y'); __makeSimple(y);...
I think it is interesting to narrow down which cases cause side-effects and which might read from a JS provided object that needs to preserve ordering. For many other things...
This is an example of where it is important to know something about the DOM implementation itself rather than just the structure of it: ```js let obj = {x: false};...
Here are some more examples of patterns that Prepack has trouble encoding right now. ```js let options = {}; options.passive = false; document.body.addEventListener('click', function() {}, options); options.passive = true; window.addEventListener('click',...
I'd expect us to be able to work around it for at least another 2 months or so. I think we probably need to iterate on the design a bit...
We use abstract values in many different ways that isn't just defining the surrounding host environment. Those have subtle differences that can't be expressed using the `__abstract()` helper. E.g. arguments...
I opened a PR that shows how I intend to use this mechanism: https://github.com/facebook/prepack/pull/2543