Sebastian Markbåge

Results 255 comments of Sebastian Markbåge

Just to be clear, you're emitting actual `NULL` characters in the strings in the text content, right? Sadly, I think this is a bug in `renderToString` and maybe `renderToReadableStream` if...

First of all, excellent PR description. The fact that you've clearly thought of many cases and reviewed the previous PR discussions and pointed out potential gaps makes it so much...

> However, relying on Vite's preload feature might be considered an "anti-RSC" concept, since it essentially bakes the entire client manifest into the main browser bundle instead of sending chunk...

> For example, one question I have is that I think the logic like wrapResourceProxy (preinit/preload wrapper) can be technically move to the module transform itself (which will be closer...

Implementing this in linear memory is fine but interaction with JavaScript GC is going to be critical for the foreseeable future IMO. Lots of critical DOM APIs (even if you...

~It didn't actually work I think partially due to how we use `refresh` to seed the cache which is going away so that needs to be refactored.~ Oh it's because...

This should not be shipped in code that's compiled for npm since it is not compatible with multiple React versions. It's also important that it doesn't ship in an RSC...

To clarify the last statement. Most testing of inline objects have compared it against the React runtime which has overhead mainly due to legacy features like the refs and the...

I think maybe one possible effect of this is that this fires while inside an offscreen tree because it's possible that the passive effects are still mounted.

Originally I only had "string" for this case because the problem is that it might also be misleading if you have custom configs that they don't show up. Since this...