Sebastian Markbåge

Results 255 comments of Sebastian Markbåge

We discussed with the team and we agreed that it makes sense to change this. Now it's just a matter of implementing it and when someone can get around to...

> the main build target for Hydrogen is Oxygen and Cloudflare Workers, which can't be run as 2 processes For cloudflare workers, you don't have to run two workers. You...

@frandiox Are you able to set up a reduced fixture similar to the one in `fixtures/flight` using Vite? I'm not familiar enough with the canonical Vite set up. Can be...

Since the latest thinking RFC has evolved to no longer represent what it's in the Webpack plugin, I think we can start landing this and then iterate on moving both...

I think that in theory it doesn't necessarily have to be separate bundles per se. Even in a single bundle it would be better if a Proxy could be avoided....

Since we've been investing more in compiler based optimizations lately there has been a number of idea lately that has spawned that would be SSR specific compilation options: - Converting...

> I think we also need make some minor changes in attemptResolveElement and resolveModelToJSON, as shown in https://github.com/facebook/react/commit/095b4f623586535cf13512c725f39d7193025432 . The reason is that, otherwise, functions and strings are not handled...

To be clear: This doesn't just affect error boundaries. It'll have to be all errors that are "caught". Because, to preserve consistency, we effectively have a built-in boundary at the...

@brandonbloom Can you elaborate more about your set up and why you wouldn't want to handle any error, including in boundaries, in `onerror`? E.g. for logging and such I'd expect...

> Rethrowing is considered uncaught. Yea, I meant the rethrow callsite is where the break point happens. That would be somewhere in the React internals way later after the source...